| Author |
Message |
Catweazle
Newbie
Joined: Aug 07, 2010
Posts: 5
Reputation: 1 
|
 Posted:
Sun Aug 08, 2010 9:52 am |
   
|
|
|
bobby
Site Admin
Joined: Jan 20, 2009
Posts: 532
Reputation: 427.2
Votes: 1
|
| Posted:
Sun Aug 08, 2010 10:12 am |
|
I will look into it asap. It sounds like the css is being included into the link. |
_________________
Tricked Out News |
|
|
|
bobby
Site Admin
Joined: Jan 20, 2009
Posts: 532
Reputation: 427.2
Votes: 1
|
| Posted:
Sun Aug 08, 2010 10:26 am |
|
Is this happening on the index page or the articles page or both? |
_________________
Tricked Out News |
|
|
|
Catweazle
Newbie
Joined: Aug 07, 2010
Posts: 5
Reputation: 1
|
| Posted:
Sun Aug 08, 2010 10:46 am |
|
Hi,
and tanks alot for taking your time to look into this!
It's on the index page - I don't have the SB links on the article page. |
| |
|
|
|
bobby
Site Admin
Joined: Jan 20, 2009
Posts: 532
Reputation: 427.2
Votes: 1
|
| Posted:
Sun Aug 08, 2010 11:52 pm |
|
In includes/nukeSEO_SB.php find:
| Code: | $bookmarkHTML = "";
$mynukeurl = str_replace('&', '&', $mynukeurl);
$mynukeurl = htmlentities(urlencode($mynukeurl));
$mynuketitle = str_replace('&', '&', $mynuketitle);
$mynuketitle = urlencode($mynuketitle);
|
Change to:
| Code: | $bookmarkHTML = "";
$mynuketitle = strip_tags($mynuketitle);
$mynukeurl = str_replace('&', '&', $mynukeurl);
$mynukeurl = htmlentities(urlencode($mynukeurl));
$mynuketitle = str_replace('&', '&', $mynuketitle);
$mynuketitle = urlencode($mynuketitle);
|
|
_________________
Tricked Out News |
|
|
|
Catweazle
Newbie
Joined: Aug 07, 2010
Posts: 5
Reputation: 1
|
| Posted:
Mon Aug 09, 2010 2:43 am |
|
Thanks alot mate!
That did the trick, sb-links are all good now 
--
Regards,
Catweazle |
| |
|
|
|
Catweazle
Newbie
Joined: Aug 07, 2010
Posts: 5
Reputation: 1
|
| Posted:
Mon Aug 09, 2010 3:57 am |
|
|
|
|
kguske
Blingaholic
Joined: May 19, 2009
Posts: 23
Reputation: 400.2
Votes: 1
|
| Posted:
Mon Sep 13, 2010 5:02 am |
|
Stripping the tags from the title doesn't fully address this issue. There are extra characters and a nbsp space that still get passed with the bookmark's title.
You could do some more fancy stripping in includes/nukeSEO_SB.php, but you shouldn't need to waste the extra processing if the correct (i.e. raw) title is passed to the bookmark function (in fact, you won't need the changes above at all).
Look at the fix this section of my (indent-enhanced) modules/News/index.php (testing comments are left for your reference so you can follow it easier):| Code: | ...
# die($title); // The title is still raw at this point
$articletitle = $title; // inserted here to pass the raw title to nukeSEO SB
if ($linklocation=="top"){
$title .= $toplink;
# } else {
# $title .= ''; // this does nothing
}
# Tricked Out News
if ($linklocation=='bottom'){
$morelink = $bottomlink .'<br>';
} else {
$morelink = '<br>';
}
# Tricked Out News
if ($bookmark=='1'){
# nukeSEO Social Bookmarking Tricked Out News
require_once('includes/nukeSEO_SB.php');
global $nukeurl;
$articleurl = $nukeurl."/article.html$sid";
# $articletitle = $title; // save the raw title above
$socialbookmarkHTML = getBookmarkHTML($articleurl, $articletitle, " ", "small");
$morelink .= ''.$socialbookmarkHTML.'';
# nukeSEO Social Bookmarking
}
# elseif ($bookmark=='0') echo ''; // this does nothing
# Control column mod Tricked Out News
... |
|
_________________
nukeSEO(tm) |
|
|
|
kguske
Blingaholic
Joined: May 19, 2009
Posts: 23
Reputation: 400.2
Votes: 1
|
| Posted:
Mon Sep 13, 2010 5:25 am |
|
I noticed that some / slashes were removed from the br tags, making the code above non-compliant (of course, you'll want to add those back if you copy that part, but it's really only there for reference). |
_________________
nukeSEO(tm) |
|
|
|
Catweazle
Newbie
Joined: Aug 07, 2010
Posts: 5
Reputation: 1
|
| Posted:
Sat Sep 18, 2010 9:04 pm |
|
I tried to comment out the two urlencode() lines,
| Code: | $mynukeurl = str_replace('&', '&', $mynukeurl);
// $mynukeurl = htmlentities(urlencode($mynukeurl));
$mynuketitle = str_replace('&', '&', $mynuketitle);
// $mynuketitle = urlencode($mynuketitle);
|
.. and the produced link is now ok.
Somewhere along the road I have lost the article title at the end of the produced link,
| Code: | | http://www.stumbleupon.com/submit?url=http://mysite.com/article5.html&title= |
.. but this is probably my own fault? - been fiddling around to much to get this right 
NB: The exact url for my article are striped and changed by your board! See the "/article5.html&title=" part of the link... |
Last edited by Catweazle on Sat Sep 18, 2010 10:25 pm; edited 1 time in total |
|
|
|
bobby
Site Admin
Joined: Jan 20, 2009
Posts: 532
Reputation: 427.2
Votes: 1
|
| Posted:
Sat Sep 18, 2010 10:20 pm |
|
|
|
|
|
|
|
